Apply metrics in rpc package#436
Closed
trinhdn2 wants to merge 5 commits intoBuildOnViction:masterfrom
trinhdn2:ft/apply_metrics_rpc
Closed
Apply metrics in rpc package#436trinhdn2 wants to merge 5 commits intoBuildOnViction:masterfrom trinhdn2:ft/apply_metrics_rpc
trinhdn2 wants to merge 5 commits intoBuildOnViction:masterfrom
trinhdn2:ft/apply_metrics_rpc
Conversation
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisite
Checklist
Added metrics:
rpc_duration_all_count- all RPC methods serving timerrpc_duration_{method}_{success|failure}- RPC method level histogram metrics, separated by RPC method and execution statusrpc_duration_{method}_{success|failure}_count- serving timer of a specific RPC methodrpc_requests- total RPC requests served gaugerpc_success- total RPC success requests served gaugerpc_failure- total RPC failed requests served gaugeExample of new metrics under prometheus format:
References: